Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): fix scorer create field cursor behavior #3307

Merged
merged 5 commits into from
Jan 7, 2025

Conversation

gtarpenning
Copy link
Member

@gtarpenning gtarpenning commented Dec 23, 2024

Description

WB-22388

Create a local state for managing text fields and only update the parent config after local change, and use the onBlur hook in the text field. This should keep the components up to date without forcibly moving the users cursor (by re-rendering the whole thing).

Testing

fix-scorer

@circle-job-mirror
Copy link

circle-job-mirror bot commented Dec 23, 2024

@gtarpenning gtarpenning marked this pull request as ready for review December 23, 2024 18:55
@gtarpenning gtarpenning requested review from a team as code owners December 23, 2024 18:55
@gtarpenning gtarpenning merged commit 06abda9 into master Jan 7, 2025
119 of 121 checks passed
@gtarpenning gtarpenning deleted the griffin/fix-scorers-autofocus branch January 7, 2025 17:14
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants